Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Accessibility) <button> found within <a> #71165

Closed
myasonik opened this issue Jul 8, 2020 · 1 comment · Fixed by #72926
Closed

(Accessibility) <button> found within <a> #71165

myasonik opened this issue Jul 8, 2020 · 1 comment · Fixed by #72926
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability WCAG A

Comments

@myasonik
Copy link
Contributor

myasonik commented Jul 8, 2020 •
edited
Loading

On the uptime page, the settings link renders a button inside of it.

https://github.com/elastic/kibana/blob/master/x-pack/plugins/uptime/public/pages/page_header.tsx#L68-L72

Also on the 404 page
https://github.com/elastic/kibana/blob/master/x-pack/plugins/uptime/public/pages/not_found.tsx#L37-L44

Also on the Certificates page
https://github.com/elastic/kibana/blob/master/x-pack/plugins/uptime/public/pages/certificates.tsx#L80-L84

Twice on the certificates page
https://github.com/elastic/kibana/blob/master/x-pack/plugins/uptime/public/pages/certificates.tsx#L90-L94

Also in the settings
https://github.com/elastic/kibana/blob/master/x-pack/plugins/uptime/public/pages/settings.tsx#L140-L144
@myasonik myasonik added bug Fixes for quality problems that affect the customer experience Project:Accessibility WCAG A Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jul 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@justinkambic justinkambic mentioned this issue Jul 22, 2020
Merged
7 tasks
@zube zube bot removed the [zube]: Done label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability WCAG A
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Uptime] Fix accessibility issue in Uptime app nav links justinkambic/kibana
3 participants
@andrewvc @myasonik @elasticmachine