Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested structure for Kibana App plugins #70452

Closed
timroes opened this issue Jul 1, 2020 · 3 comments
Closed

Nested structure for Kibana App plugins #70452

timroes opened this issue Jul 1, 2020 · 3 comments
Labels
discuss Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Jul 1, 2020

Since #68811 we can now group plugins together into folders. I think we should discuss how we want to group the Kibana App plugins into folders, since we're having quiet a bunch of them. I'd put up the following structure up for discussion and would value any input:

  • plugins
    • discover (leave at the root level for now)
    • dashboard (leave that at the root level for now)
    • timelion (the application, leave this since it's scheduled for removal in 8.0)
    • management
      • management_app (owned by App Arch)
      • advanced_settings
      • saved_objects_management (owned by Platform)
    • visualizations
      • visualize (the application)
      • visualizations (the infrastructure, planned to be merged together in long run with visualize)
      • vis_default_editor (rename to default_editor potentially, since now nested)
      • vis_type_*
      • region_map
      • tile_map
  • x-pack/plugins (leave everything here on top level, since there's currently not really any more reasonable grouping)
    • discover_enhanced
    • dashboard_enhanced
    • graph
    • lens
    • dashboard_mode (scheduled for removal in 8.0)

cc @elastic/kibana-app-arch and @elastic/kibana-platform since this makes some assumptions about your plugins too.

@timroes timroes added discuss Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 1, 2020
@pgayvallet
Copy link
Contributor

Moving saved_objects_management under a management folder/section SGTM

@lukeelmers
Copy link
Member

@timroes Just as a heads up, Josh recently made a wider proposal for updating the repo directory structure in #71566

@timroes
Copy link
Contributor Author

timroes commented Jul 27, 2020

Closing this in favor of #71566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants