Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Return status code 403 instead of 500 for log analysis routes when missing ml capabilities #70414

Closed
weltenwort opened this issue Jul 1, 2020 · 3 comments · Fixed by #74506
Closed

[Logs UI] Return status code 403 instead of 500 for log analysis routes when missing ml capabilities #70414

weltenwort opened this issue Jul 1, 2020 · 3 comments · Fixed by #74506
Assignees
@Kerry350
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Milestone
Logs UI 7.10

Comments

@weltenwort
Copy link
Member

weltenwort commented Jul 1, 2020 •
edited by zube bot
Loading

Summary

With the addition of capability checks in #70069 the log analysis result routes will return the HTTP status code 500 when the underlying ML service throws an error resulting from missing capabilities. The routes should catch that and return a status code 403 instead.
@weltenwort weltenwort added chore Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jul 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort added this to the Logs UI 7.9 milestone Jul 21, 2020
@jasonrhodes
Copy link
Member

@weltenwort is this a bug for 7.9 or an enhancement for 7.10?

@weltenwort
Copy link
Member Author

These routes behave differently since the ML permission changes, so I intended to treat them as a bug - unless you object.

@weltenwort weltenwort added bug Fixes for quality problems that affect the customer experience and removed chore labels Jul 27, 2020
@weltenwort weltenwort modified the milestones: Logs UI 7.9, Logs UI 7.10 Jul 28, 2020
@Kerry350 Kerry350 self-assigned this Aug 5, 2020
@Kerry350 Kerry350 mentioned this issue Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kerry350 Kerry350

Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
Logs UI 7.10
Development

Successfully merging a pull request may close this issue.

[Logs UI] Return 403s rather than 500s for ML privilege errors Kerry350/kibana
4 participants
@jasonrhodes @Kerry350 @weltenwort @elasticmachine