Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Provide preview-icons of layer-type #70266

Closed
thomasneirynck opened this issue Jun 29, 2020 · 16 comments · Fixed by #78650
Closed

[Maps] Provide preview-icons of layer-type #70266

thomasneirynck opened this issue Jun 29, 2020 · 16 comments · Fixed by #78650
Assignees
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Jun 29, 2020

The add-layer type has many layer types available. From the description it is not always clear how exactly that layer would look like on a map.

e.g. a heatmap, a choropleth layer, a cluster-layer, a document layer,... all have very "characteristic" look&feel when they are added on a map.

It would be nice to show a little icon in the wizard (either as a replacement for the source-type icon, or in a tooltip) that shows to the user how that layer would look like. e.g. the heatmap-card could show the heatmap-color blobs, the choropleth-layer could show some thematically colored cartoon map, ...

CartoDB has similar UX.

cc @kmartastic @miukimiu @jsanz

@thomasneirynck thomasneirynck added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result labels Jun 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@jsanz
Copy link
Member

jsanz commented Jun 30, 2020

Just to be sure, you mean changing the current big icons by something that depicts each layer type, right? I like the idea

image

@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Jun 30, 2020

changing the current big icons by something that depicts each layer type

yes. iso Elasticsearch logo for all these layer-types, we'd have little preview-icons.

e.g. in CartoDb we have these 3 little icons

image

left: choropleth
middle: cluster/grid
right: heatmap

We could have something similar for lines with Point-to-point, or some "point/line/poly"-icon for Documents.

The "Elasticsearch icon" is less useful now, since we have a separate "Elasticsearch"-facet to group ES-sources.

@jsanz
Copy link
Member

jsanz commented Jun 30, 2020

CARTO also uses that approach for the datasets layer to indicate the geometry type

image

ArcGIS Online also uses icons for content types

image

@kmartastic
Copy link
Contributor

Agree that this is better for users that know the results/analysis they want to perform, instead of needing to understand the data source.

@elizabetdev
Copy link
Contributor

@thomasneirynck, @jsanz, and @kmartastic,

What do you think of these icons?

Layers Preview icons

@thomasneirynck
Copy link
Contributor Author

Nice, thx @miukimiu!

My 2c:

choropleth

+1 looks great

clusters and grids

+1 great. I would consider removing the polygon background.

Is it possible to add something with squares to represent the "grids"-option? (the bubbles already represent the "clusters"-options

e.g.:

image

vs

image

are the same data. The top is "grids", the bottom is "clusters". Users can edit them interchangeably.

Documents

+1, great

Point to point

I would consider removing the edge-node effect, it kind of looks like a triangle or network. I think what it looks like more often than not in practice (e.g. network traffic) is a sort of "hairball" with a few centers connected from the outside.

image

I'd also consider removing the "background"-polygons. That "point2point" is just lines.

Heatmap

+1, great. I'd consider removing the background-polygons. The layer is just the heatmap-blobs.

@elizabetdev
Copy link
Contributor

Hi @thomasneirynck,

I did a few updates based on your comments. What do you think of the new versions?

Light theme@2x

Also, I tried to see how it might look like in dark mode. I will need to adjust the dark theme colors when implementing.

Dark theme@2x

@thomasneirynck
Copy link
Contributor Author

@miukimiu all looks great to me!

any thoughts @kmartastic @jsanz @nreese ?

@kmartastic
Copy link
Contributor

Wow. These revisions are spot-on. Nice work @miukimiu.

@jsanz
Copy link
Member

jsanz commented Sep 21, 2020

Sorry I missed the first iteration @miukimiu 😓

I love the new icons in monochrome, but would it make sense to add to them some color to align with the other layers icons? Or the gray theme is intentioned, so the solution layers stand out a bit more?

@elizabetdev
Copy link
Contributor

I just picked a gray theme to make it easier. But @jsanz I agree, the other icons stand out more. Let me try to add color.

@elizabetdev
Copy link
Contributor

@jsanz, I tested adding colors and it didn't look good.

@jsanz, @kmartastic, @thomasneirynck what do you think if we also change the icons for the following layers to also have a preview or to make them more similar to the new ones? This way, only the solutions layers would have a different type of icons.

Screenshot 2020-09-29 at 12 15 17

@jsanz
Copy link
Member

jsanz commented Sep 29, 2020

+1 on having a full coherent icon set, leaving the solution layers to stand out on their own

@kmartastic
Copy link
Contributor

kmartastic commented Sep 29, 2020

@jsanz, @kmartastic, @thomasneirynck what do you think if we also change the icons for the following layers to also have a preview or to make them more similar to the new ones? This way, only the solutions layers would have a different type of icons.

What do you mean by "preview"? Are there other types of icons besides "preview"?

Otherwise, this plan sounds good.

@elizabetdev
Copy link
Contributor

Hi @kmartastic,

Sorry for the late reply. I'm back from PTO.

By preview, I mean to show how that layer would look like on a map. But in case it's not possible, because it's difficult to represent it. At least I can make icons that seem to belong to the same "family".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants