Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace KQL cancellation timeout with manual timeout #70231

Closed
Tracked by #166068
lukasolson opened this issue Jun 29, 2020 · 3 comments
Closed
Tracked by #166068

Replace KQL cancellation timeout with manual timeout #70231

lukasolson opened this issue Jun 29, 2020 · 3 comments
Assignees
@lukasolson
Labels
Feature:KQL KQL Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@lukasolson
Copy link
Member

Currently, we place a couple of limits on the value suggestion requests we send to Elasticsearch. We send a timeout parameter in addition to terminate_after. This isn't ideal since timeout is per shard rather than for the entire query.

We can, instead, after 1s, actually cancel the query after our desired timeout rather than send the parameter in the request itself.
@lukasolson lukasolson added enhancement New value added to drive a business result loe:small Small Level of Effort Feature:KQL KQL Team:AppArch labels Jun 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jun 2, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Nov 22, 2021
@petrklapka petrklapka added Feature:Search Querying infrastructure in Kibana Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:AppServicesSv labels Nov 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@lukasolson lukasolson added :DataDiscovery/fix-it-week and removed enhancement New value added to drive a business result labels Feb 22, 2023
@lukasolson lukasolson self-assigned this Aug 14, 2023
@kertal kertal added the Icebox label Feb 23, 2024
@kertal kertal mentioned this issue Feb 23, 2024
Open
@kertal
Copy link
Member

kertal commented Feb 23, 2024

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as completed Mar 7, 2024
@kertal kertal reopened this Mar 7, 2024
@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Mar 29, 2024
@github-project-automation github-project-automation bot moved this to Done in current release in kibana-app-arch Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukasolson lukasolson

Labels
Feature:KQL KQL Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
kibana-app-arch
Status: Done in current release
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kertal @lukasolson @elasticmachine @petrklapka