Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] XY and pie charts don't respect dark mode #70181

Closed
flash1293 opened this issue Jun 29, 2020 · 3 comments · Fixed by #69695
Closed

[Lens] XY and pie charts don't respect dark mode #70181

flash1293 opened this issue Jun 29, 2020 · 3 comments · Fixed by #69695
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens regression Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Kibana version: master

Describe the bug:

When in dark mode, xy and pie charts in Lens are rendered with a white background

Steps to reproduce:

  1. Enable dark mode
  2. Go to lens
  3. Configure a chart

Expected behavior:

Dark mode is respected

Screenshots (if relevant):
Screenshot 2020-06-29 at 11 12 28

@nickofthyme Could this be related to a recent elastic-charts updadte?
@flash1293 flash1293 added bug Fixes for quality problems that affect the customer experience regression Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@nickofthyme nickofthyme mentioned this issue Jun 29, 2020
Merged
2 tasks
@nickofthyme nickofthyme linked a pull request Jun 29, 2020 that will close this issue
Fix discover, tsvb and Lens chart theming issues #69695
Merged
2 tasks
@nickofthyme
Copy link
Contributor

@flash1293 There was is a similar issue with discover and TSVB due to some background contrast changes in EC. I'll ensure this PR #69695 fixes this issue too.

@flash1293
Copy link
Contributor Author

That's great, thanks @nickofthyme 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens regression Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix discover, tsvb and Lens chart theming issues nickofthyme/kibana
3 participants
@flash1293 @elasticmachine @nickofthyme