Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Show beta/experimental badges and tooltips on integrations #70026

Closed
hbharding opened this issue Jun 26, 2020 · 4 comments · Fixed by #70997
Closed

[Ingest Manager] Show beta/experimental badges and tooltips on integrations #70026

hbharding opened this issue Jun 26, 2020 · 4 comments · Fixed by #70997
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@hbharding
Copy link
Contributor

hbharding commented Jun 26, 2020

See design issue for more information.

Related to #64869.

Requirements

  • By default, experimental integrations will not be shown.
  • When enabled, show an "experimental" badge on the integration card
  • On integration detail page, show "experimental" badge in header area next to the name of the integration. Hovering on the experimental badge will show a tooltip.
  • Show a "beta" badge on integration card if it's in beta. Beta integrations are always shown and can't be disabled. Also show the beta badge on the integration detail page header.
  • When experimental integrations are disabled, the numbers shown in the category filters should reflect that. I.e. don't count experimental integrations in the categories count, and if a category contains 100% experimental, don't show the category at all.
@hbharding hbharding added Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:beta1 labels Jun 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jen-huang jen-huang self-assigned this Jul 3, 2020
@ph
Copy link
Contributor

ph commented Jul 6, 2020

@jen-huang I've nearly missed this, by default all integration package will now be experiemental, because we want to make sure we can make breaking changes.

We can remove this as the behavior? "By default, experimental integrations will not be shown."

@jen-huang
Copy link
Contributor

@ph Thanks for the info. I'll adjust this issue to remove the toggle functionality, so that implementation is just for showing experimental/beta badges.

@jen-huang jen-huang changed the title [Ingest Manager] Allow user to toggle experimental integrations on/off [Ingest Manager] Show beta/experimental badges and tooltips Jul 6, 2020
@jen-huang jen-huang changed the title [Ingest Manager] Show beta/experimental badges and tooltips [Ingest Manager] Show beta/experimental badges and tooltips on integrations Jul 6, 2020
@jen-huang
Copy link
Contributor

Hi @ph, I thought about this some more, and I was wondering if marking all packages as "beta" is sufficient for allowing breaking changes? From what I can tell, most of our production packages are already marked as beta.

IIRC, the "experimental" flag was primarily intended for package contributors to test their own packages locally, and be able to see them via toggle in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants