Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Name changes tracking issue #70024

Closed
hbharding opened this issue Jun 25, 2020 · 5 comments · Fixed by #70259
Closed

[Ingest Manager] Name changes tracking issue #70024

hbharding opened this issue Jun 25, 2020 · 5 comments · Fixed by #70259
Assignees
Labels
design Meta Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@hbharding
Copy link
Contributor

hbharding commented Jun 25, 2020

Summary

This issue tracks all the name changes we've discussed and want to implement for Ingest Manager beta 1. Most importantly, we want to remove all references to data sources and data streams / streams in the UI, but this list includes a few others for tracking purposes. If you find something that's not covered here, please add it to the list!

For each item in the list, we can link the PR or issue that will address the name change. Many of these issues could be addressed in a single PR, but others might want to be done separately.

These changes can be previewed in the Figma file

Overview page

Issue Where What changed?
#70828 Configuration panel Change panel header to say "Agent configurations". Change "Data sources" to say "Configured integrations"

Integrations

Issue Where What changed?
#70033? Add integration page Header should include icon in title and say "Add {integrationName} integration". Remove the integration key:value pair on the right. Breadcrumb should say "Add integration"

Agent configurations

Issue Where What changed?
#70259 List page Change "data sources" table column header to "Integrations"
#70828 and #70259 Detail page Rename "Data sources" tab to "Integrations". In table, 1st column "Data source" should say "Integration". Remove "Streams" column. "Add data source" button should say "Add integration"
#70828 Add integration breadcrumb Change "Add data source" to "Add integration"
#70259 Add integration - step 2 Change "Define your data source" to "Configure integration"
#70033 Add integration - step 3 Combine step 3 with step 2, and remove the X/X streams enabled" count Note: this should be done as part of #70033 as it involves more than naming.

Fleet

Issue Where What changed?
#70828 Enroll agent flyout In step 2, change "data sources" to "integrations"
#70259 Agent table Change "Configuration" column header to "Agent config"
#70259 Agent filter option Change "Configs" to "Agent config"
#70259 Enrollment token table Change "Config" to "Agent config"

Datasets (formerly Data streams)

Issue Where What changed?
#70840 Header + Breadcrumb This page is now called "Datasets"
#70840 Search box "Filter data streams" should say "Search for datasets"

Miscellaneous

Issue Where What changed?
#70840 Navigation Change "Data streams" to "Datasets"

Note: Any navigation changes should be reflected in the breadcrumbs as well

@hbharding hbharding added Meta design Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:beta1 labels Jun 25, 2020
@hbharding hbharding self-assigned this Jun 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph
Copy link
Contributor

ph commented Jun 29, 2020

@neptunian Looking at the list above, I think the priority is OK.
Overview page, Integrations, Agent configurations should be done and we can move to other pages.

@neptunian
Copy link
Contributor

@jen-huang advised holding off until #70018 is complete which should by merged very soon.

@jen-huang
Copy link
Contributor

Hi, I have a draft PR up for the above issue: #70259. This should get merged in the next few days.

As part of the work, I renamed any usages of data source(s) in the UI, but these were done hastily and should be double checked during the work for this issue to make sure they match with the wording provided here.

Also as part of the above work I had to change a few API and app routing paths to align with the renaming, so it would be good to check associated routes for the rest of the items on this issue too.

@ph
Copy link
Contributor

ph commented Jul 14, 2020

closing since all the related work have been merged

@ph ph closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Meta Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants