Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] [Alerting] Expand executor tests #69261

Closed
Kerry350 opened this issue Jun 16, 2020 · 2 comments · Fixed by #75764
Closed

[Logs UI] [Alerting] Expand executor tests #69261

Kerry350 opened this issue Jun 16, 2020 · 2 comments · Fixed by #75764
Assignees
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.10.0 v8.0.0
Milestone

Comments

@Kerry350
Copy link
Contributor

Kerry350 commented Jun 16, 2020

Following on from the work in #68250 the logs alerts executor tests now only cover the ungrouped scenario, and not grouped scenarios.

This ticket should cover two sets of changes:

  • The grouped scenario should be tested.

  • The executor unit tests should be simplified in their approach, this wasn't as relevant before, but it is now there's two forks of logic. Currently the unit tests are heavily mocked all the way through to the callCluster method. We can simplify these tests by calling and testing smaller functions separately. Rather than trying to mimic an end-to-end flow via unit tests.

@Kerry350 Kerry350 added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 labels Jun 16, 2020
@Kerry350 Kerry350 added this to the Logs UI 7.9 milestone Jun 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@jasonrhodes
Copy link
Member

+1 on getting this in sooner than later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants