Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Plugin lifecycle setup step needs to be synchronous #68292

Closed
tsullivan opened this issue Jun 4, 2020 · 1 comment · Fixed by #68326
Closed

[Reporting] Plugin lifecycle setup step needs to be synchronous #68292

tsullivan opened this issue Jun 4, 2020 · 1 comment · Fixed by #68326
Labels
Feature:Reporting:Framework Reporting issues pertaining to the overall framework needs-team Issues missing a team label

Comments

@tsullivan
Copy link
Member

Kibana version: 7.9

Describe the bug:
Currently the setup step of the Reporting lifecycle must wait for browsers to be installed. This is an asynchronous step that could involve waiting for the zip files of our browser build to download.

In legacy, this was fine because setup time wasn't limited. We were able to make the choice to initialize HeadlessChromiumDriverFactory at setup.

This is blocking Kibana developers that don't have the browser zip files cached in their local workspace. The blocker is lifted if the download eventually happens to complete before the setup timeout.
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@tsullivan tsullivan mentioned this issue Jun 4, 2020
Merged
3 tasks
@sophiec20 sophiec20 added Feature:Reporting:Framework Reporting issues pertaining to the overall framework and removed (Deprecated) Team:Reporting Services labels Aug 21, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Reporting:Framework Reporting issues pertaining to the overall framework needs-team Issues missing a team label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Reporting] Convert plugin setup and start to synchronous tsullivan/kibana
3 participants
@tsullivan @sophiec20 @elasticmachine