Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a IP lookup field formatter #68216

Closed
timroes opened this issue Jun 4, 2020 · 5 comments
Closed

Add a IP lookup field formatter #68216

timroes opened this issue Jun 4, 2020 · 5 comments
Labels
enhancement New value added to drive a business result Feature:FieldFormatters good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@timroes
Copy link
Contributor

timroes commented Jun 4, 2020

We currently have a static lookup field formatter which allows to map values to other strings. This is sometimes used by users to assign known ip addresses a name, like

screenshot-20200604-092407

It would be nice if we would have a more specific "IP lookup" field formatter available, that allows specifying ip ranges/subnets as keys, so that users could e.g. do something like 10.0.10.0/24 -> Office Amsterdam more easily.

@timroes timroes added enhancement New value added to drive a business result Team:AppArch Feature:FieldFormatters labels Jun 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@timroes timroes added the good first issue low hanging fruit label Jun 4, 2020
@archon810
Copy link

Ideally, for the case of a subnet/IP range, the IP would be visible as well, not just the replacement value. Perhaps a special variable for the value of the matched key ($VALUE or something) or just the ability to specify a field name (source.ip)?

@timroes
Copy link
Contributor Author

timroes commented Jun 4, 2020

We could only use the original value as e.g. {value} in there. We don't have the full document in all cases that will be formatted (e.g. imagine a chart were we aggregated on the field, so this will be a bucket in the elasticsearch response, there are no "individual" field of any document left, except the value for that bucket. But making {value} available as the original value, is something that we should add for this one (I also see how this is more use for this, than for the regular lookup field formatter).

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 16, 2021
@ppisljar
Copy link
Member

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
@archon810
Copy link

This would still be a nice feature to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:FieldFormatters good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Development

No branches or pull requests

4 participants