Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Prevent user from adding more than 1 Endpoint data source #67693

Closed
hbharding opened this issue May 28, 2020 · 4 comments
Closed
Assignees
Labels
design loe:small Small Level of Effort Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@hbharding
Copy link
Contributor

For technical reasons, there can only be 1 endpoint datasource per agent configuration. We need to prevent the user being able to add a 2nd endpoint datasource if one already exists, and we may want to include an explanation why.

@hbharding hbharding added design Team:Fleet Team label for Observability Data Collection Fleet team labels May 28, 2020
@hbharding hbharding self-assigned this May 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@hbharding hbharding added loe:small Small Level of Effort [zube]: Ready and removed [zube]: Ready labels May 28, 2020
@hbharding
Copy link
Contributor Author

After talking with the group:

When adding an integration from an agent configuration page, simply don't show the Endpoint integration in step 1 where we list available integrations if Endpoint is already configured for an agent config. This prevents the user from being able to add a 2nd Endpoint integration to the same config.

When adding an integration like Endpoint from an integration detail page, in step 1 where user selects an agent configuration, we will show the agent configurations as disabled if they already have Endpoint configured.

@paul-tavares
Copy link
Contributor

Cool. Thanks @hbharding for posting that. Just to be clear, although you detail the UI changes above, the enforcement of this will also still be done at the API level, correct?

@jen-huang
Copy link
Contributor

@paul-tavares Yes we should make sure to do this at API level too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design loe:small Small Level of Effort Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

5 participants