Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[esaggs] Bucket aggregation without a metric should be supported #67525

Closed
Tracked by #60126
wylieconlon opened this issue May 27, 2020 · 2 comments · Fixed by #110095
Closed
Tracked by #60126

[esaggs] Bucket aggregation without a metric should be supported #67525

wylieconlon opened this issue May 27, 2020 · 2 comments · Fixed by #110095
Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort

Comments

@wylieconlon
Copy link
Contributor

wylieconlon commented May 27, 2020

Part of #61768

I would expect that an implicit Count metric would be inserted by esaggs when not configured by the user. This would solve the issues we are seeing in Lens, which are:

@wylieconlon wylieconlon added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Team:AppArch labels May 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Jun 2, 2020
@lukeelmers lukeelmers self-assigned this Jun 8, 2020
@flash1293
Copy link
Contributor

Looked into this with @dej611 and discovered a confusing behavior around that at the moment:
If there are no metrics configured, esaggs just returns an empty table as long as metricsAtAllLevels are set to false, but it crashes with an uncaught exception if it's set to true. This will probably be fixed once we support metric-less esaggs calls explicitly.

@lukeelmers lukeelmers removed their assignment Dec 14, 2020
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Apr 20, 2021
@petrklapka petrklapka added 1 and removed 1 labels May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants