Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Timelion UI settings #66873

Closed
flash1293 opened this issue May 18, 2020 · 2 comments
Closed

Migrate Timelion UI settings #66873

flash1293 opened this issue May 18, 2020 · 2 comments
Labels
Feature:NP Migration Feature:Timelion Timelion app and visualization Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

The advanced settings of timelion are registered in the legacy platform (https://github.com/flash1293/kibana/blob/3667647aa24510c10422ec9c1e33c1baa6549380/src/legacy/core_plugins/timelion/index.ts#L65). Some of them are only used in the deprecated timelion app, but some of them have to be migrated to the new platform because vis_type_timelion also relies on them.

  • timelion:es.timefield
  • timelion:es.default_index
  • timelion:target_buckets
  • timelion:max_buckets
  • timelion:min_interval
  • timelion:graphite.url
  • timelion:quandl.key

These ui-settings settings should be moved into vis_type_timelion similar to #63597
@flash1293 flash1293 added Feature:Timelion Timelion app and visualization Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:NP Migration labels May 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor Author

Done by timelion app migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:NP Migration Feature:Timelion Timelion app and visualization Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flash1293 @elasticmachine