Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] Migrate last pieces of legacy fixture code #66063

Closed
gmmorris opened this issue May 11, 2020 · 2 comments · Fixed by #74470
Closed

[Alerting] Migrate last pieces of legacy fixture code #66063

gmmorris opened this issue May 11, 2020 · 2 comments · Fixed by #74470
Assignees
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@gmmorris
Copy link
Contributor

We couldn't migrate the following fixtures:

  1. Slack - as it needs custom error responses. Issues submitted to Platform: kibanaResponseFactory should support entirely custom responses #65045
  2. Webhook - as it uses a custom authorisation type which Platform doesn't expose anymore.
    server.auth.scheme('identifyCredentialsIfPresent', function identifyCredentialsIfPresent(

Regarding Webhook we should look into whether this custom auth is really needed and if so - submit an issue to Platform. Hopefully we can just change how we test this.

@gmmorris gmmorris added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels May 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@pmuellr
Copy link
Member

pmuellr commented Jul 9, 2020

Slack - as it needs custom error responses. Issues submitted to Platform: #65045

That issue was closed with "The recommended solution for this particular use-case is to switch to another HTTP server", so I think we'll have a bit more work to do here than originally thought. Basically, we need to pull in some other HTTP server or use node http APIs bare (painful) instead of the in the FTS we currently run them with.

Webhook - as it uses a custom authorisation type which Platform doesn't expose anymore.

I don't know much about this one, but if we do end up needing a new server for Slack, then probably the easiest way to deal with Webhook is to also use the separate server for that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants