Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move collectors defined in the telemetry plugin out of it #65515

Closed
afharo opened this issue May 6, 2020 · 3 comments · Fixed by #65663
Closed

Move collectors defined in the telemetry plugin out of it #65515

afharo opened this issue May 6, 2020 · 3 comments · Fixed by #65663

Comments

@afharo
Copy link
Member

afharo commented May 6, 2020

There are a few general collectors defined in the telemetry plugin: https://github.com/elastic/kibana/tree/452193fdba7c77815472889d1715b1ca341530ba/src/plugins/telemetry/server/collectors

We should extract them from this plugin because these collectors are also used by the monitoring plugin when retrieving Kibana stats (for monitoring purposes, not telemetry) and if telemetry.enabled: false, we won't register these collectors

@elasticmachine
Copy link
Contributor

Pinging @elastic/pulse (Team:Pulse)

@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented May 6, 2020

@afharo would you consider this a bug or a normal issue from changes that happen over releases? I assume the priority is fairly high.

@afharo
Copy link
Member Author

afharo commented May 7, 2020

I'd say to fix it ASAP. But I doubt it needs to be included in patch releases. I think targeting it for 7.9 should be enough.

It's also a very simple one: simply move the collectors to another plugin (either to a new plugin kibana_usage_collectors that can be maintained by the NP/core team in the future or to the usage_collection itself since they are core collectors). I can create a PR today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants