Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPM] Revisit dedup logic for template generation #64901

Open
jonathan-buttner opened this issue Apr 30, 2020 · 1 comment
Open

[EPM] Revisit dedup logic for template generation #64901

jonathan-buttner opened this issue Apr 30, 2020 · 1 comment
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture

Comments

@jonathan-buttner
Copy link
Contributor

The if logic to determine when to merge fields within the dedupFields() function here: https://github.com/elastic/kibana/blob/master/x-pack/plugins/ingest_manager/server/services/epm/fields/field.ts#L110
is getting complex. Let's revisit it to see if we have specify it's behavior and simplify it a bit.

Reference PR: #64829
@jonathan-buttner jonathan-buttner added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:beta1 labels Apr 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jonathan-buttner jonathan-buttner mentioned this issue Apr 30, 2020
Merged
@ph ph added the technical debt Improvement of the software architecture and operational architecture label May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ph @elasticmachine @jonathan-buttner