Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race conditions in the platform lifecycles. #64785

Closed
mshustov opened this issue Apr 29, 2020 · 2 comments
Closed

Fix race conditions in the platform lifecycles. #64785

mshustov opened this issue Apr 29, 2020 · 2 comments
Labels
enhancement New value added to drive a business result Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

mshustov commented Apr 29, 2020 •
edited
Loading

Platform integration tests are flaky due to possible race conditions when a test-suite calls shutdown before platform completes asynchronous setup & start lifecycle.

#64487 solves the problem temporarily. We need a more sound solution.
Probably we should consider separating use-cases platform stops due to an internal problem / platform should stop due to an external command.
@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform enhancement New value added to drive a business result labels Apr 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@mshustov mshustov mentioned this issue Jan 6, 2021
Closed
@pgayvallet
Copy link
Contributor

This has been somewhat addressed, now once the stop sequence was initiated, any error thrown from the other lifecycles are ignored, so that only the initial call to stop is the source of truth. This also (mostly) fixed the rare cases of flakiness related to this race condition in IT tests.

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pgayvallet @mshustov @elasticmachine