Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Plugin bundle optimizations #64589

Closed
rylnd opened this issue Apr 27, 2020 · 5 comments · Fixed by #78992
Closed

[SIEM] Plugin bundle optimizations #64589

rylnd opened this issue Apr 27, 2020 · 5 comments · Fixed by #78992
Assignees
@rylnd
Labels
chore Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0

Comments

@rylnd
Copy link
Contributor

rylnd commented Apr 27, 2020

As discussed in #64251 (comment), we are unnecessarily pulling application code into our plugin, resulting in a larger than necessary initial plugin bundle.

We should refactor those imports to rely on as little application code as possible.
@rylnd rylnd self-assigned this Apr 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

This was referenced Apr 27, 2020
Merged
Merged
@cnasikas cnasikas mentioned this issue Apr 29, 2020
Closed
@rylnd
Copy link
Contributor Author

rylnd commented Apr 29, 2020

Closed by #64665

@rylnd rylnd closed this as completed Apr 29, 2020
@rylnd
Copy link
Contributor Author

rylnd commented Aug 20, 2020

Reopening this as a post-7.9 task; it looks like we've grown in size pretty significantly since then. This may just be new endpoint/response code, but I think it warrants another audit.

@rylnd rylnd reopened this Aug 20, 2020
@rylnd
Copy link
Contributor Author

rylnd commented Sep 1, 2020

For anyone that might pick this up: #71843 has instructions on how to start analyzing our bundles.

@rylnd rylnd linked a pull request Sep 30, 2020 that will close this issue
[Security Solution] Reduce initial bundle size #78992
Merged
1 task
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rylnd rylnd

Labels
chore Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] Reduce initial bundle size oatkiller/kibana
3 participants
@rylnd @MindyRS @elasticmachine