Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Remove hard dependency on APM #64345

Closed
simianhacker opened this issue Apr 23, 2020 · 1 comment · Fixed by #64952
Closed

[Metrics UI] Remove hard dependency on APM #64345

simianhacker opened this issue Apr 23, 2020 · 1 comment · Fixed by #64952
Assignees
Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@simianhacker
Copy link
Member

simianhacker commented Apr 23, 2020

Right now there is a hard dependency for APM to be enabled for the Metrics UI. This was originally introduced into the detail page metadata API for adding an APM section to that page. That PR was never merged because we decided to take a different approach.

We need to remove our hard dependency to the APM plugin. In 7.6 if you disable APM we throw a fatal error because the function provided by the APM plugin is undefined. In master (and anything with the new platform), disabling APM also disables Metrics and Logs UI because there is a hard dependency in the framework.

@simianhacker simianhacker added [zube]: Ready Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Apr 23, 2020
@simianhacker simianhacker self-assigned this Apr 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants