Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] ML Permissions are verified on the backend #62532

Closed
rylnd opened this issue Apr 3, 2020 · 4 comments
Closed

[SIEM] ML Permissions are verified on the backend #62532

rylnd opened this issue Apr 3, 2020 · 4 comments
Labels
enhancement New value added to drive a business result Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.0 v8.0.0

Comments

@rylnd
Copy link
Contributor

rylnd commented Apr 3, 2020

Prior to the availability of the ML plugin contract, we were unable to perform these checks.

This causes the following errant behaviors:

  • API users can create/update ML Rules regardless of their ML permissions.
  • UI users can create an enabled ML Rule by importing it

NB that in both of the above situations, the user must have a valid ML license (platinum/trial).

This might merit a separate PR, but rule execution is going to be even trickier: since the rule executes with the permissions of the last person who modified it, ML services will need to be refactored to accept a non-extended cluster client (currently they expect paths like ml.jobs which do not exist on the scoped alerting client). Even then, a user could lose their ML permissions and the job will happily continue to execute with its own (now outdated) copy of that user's permissions.

@rylnd rylnd added enhancement New value added to drive a business result Team:SIEM v8.0.0 v7.8.0 labels Apr 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@rylnd
Copy link
Contributor Author

rylnd commented Apr 8, 2020

Related issue for ML: #62886

@rylnd
Copy link
Contributor Author

rylnd commented May 12, 2020

Closed by #65583

@rylnd rylnd closed this as completed May 12, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

3 participants