Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] Show a warning when creating an alert if no actions are defined #61522

Closed
Zacqary opened this issue Mar 26, 2020 · 5 comments · Fixed by #79892
Closed

[Alerting] Show a warning when creating an alert if no actions are defined #61522

Zacqary opened this issue Mar 26, 2020 · 5 comments · Fixed by #79892
Assignees
Labels
Feature:Alerting good first issue low hanging fruit Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) UX

Comments

@Zacqary
Copy link
Contributor

Zacqary commented Mar 26, 2020

Kibana version: 7.8.0

Screen Shot 2020-03-26 at 2 14 59 PM

User should not be able to save an alert if all fields are filled out but no actions are defined. (Maybe add a "required" label to the actions section?)

@Zacqary Zacqary added bug Fixes for quality problems that affect the customer experience Feature:Alerting Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.7.0 labels Mar 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary
Copy link
Contributor Author

Zacqary commented Apr 1, 2020

Upon investigation this turns out to be a question for @elastic/kibana-alerting-services. Some alert types may need zero-action alerts, so we need to figure out the UX here for alert types that wouldn't be useful without actions.

@pmuellr
Copy link
Member

pmuellr commented Apr 1, 2020

It wasn't clear from the offline discussion on this, whether this is causing an error in metrics, or not. Eg, does an alert with no actions break something in metrics? Generally speaking, a solution shouldn't have to know whether an alert has any actions set for it or not.

Alerts with no actions has been supported since we started, for various scenarios, but we understand that they could be considered "incomplete", depending on the scenario.

Current thinking is that we could put some kind of warning banner somewhere, indicating no actions have been set on the alert, as a reminder to the user. But I don't believe there are any plans to enforce that alerts must have at least one action.

@mikecote
Copy link
Contributor

mikecote commented Apr 3, 2020

It was discussed during today's sync that the best option would be to show a confirmation modal on save when no actions exists.

@Zacqary Zacqary added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 and removed bug Fixes for quality problems that affect the customer experience v7.7.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Metrics UI Metrics UI feature labels Apr 6, 2020
@Zacqary Zacqary changed the title [Metrics Alerts] Disallow creating an alert unless at least one action is defined [Alerting] Show a warning when creating an alert if no actions are defined Apr 6, 2020
@Zacqary
Copy link
Contributor Author

Zacqary commented Apr 6, 2020

Reassigning this to @elastic/kibana-alerting-services

@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting good first issue low hanging fruit Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants