Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Trigger a filter action on click in datatable visualization #61417

Closed
mbondyra opened this issue Mar 26, 2020 · 6 comments · Fixed by #63840
Closed

[Lens] Trigger a filter action on click in datatable visualization #61417

mbondyra opened this issue Mar 26, 2020 · 6 comments · Fixed by #63840
Assignees
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0 v8.0.0

Comments

@mbondyra
Copy link
Contributor

As a lens user, I want to have a possibility to filter in/out datatable values by 'break down by' values.

image

There have to be two handles added - filtering out and in.

This is continuation of #52806

@mbondyra mbondyra added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0 v8.0.0 labels Mar 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mbondyra mbondyra self-assigned this Apr 15, 2020
@mbondyra
Copy link
Contributor Author

mbondyra commented Apr 16, 2020

@cchaos @AlonaNadler regarding the design of the filter zooms and tooltip, should we follow the same as in the classic datatable visualization (1) or should we align with what EUI provides (2)?
1:
image

2:
image

@cchaos
Copy link
Contributor

cchaos commented Apr 16, 2020

Hmm, right now I would say neither in terms of UI. Give me some time to gather some mocks and discuss with those working on the Discover redesign.

@timroes
Copy link
Contributor

timroes commented Apr 16, 2020

And let's not forget there is still the Inspector which got the following design:

screenshot-20200416-203900

So if we come up with a different solution now, we might want to address that also in the inspector at least.

@mbondyra
Copy link
Contributor Author

@cchaos any update on this one?

@cchaos
Copy link
Contributor

cchaos commented Apr 23, 2020

The end result of many conversations is to use the same pattern as the Inspect table. Just need to get consensus on which icons to use, the simple circles or magnify versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants