Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving Discover/Visualize/Dashboard/Graph saved objects allows duplicate titles #60735

Closed
kertal opened this issue Mar 20, 2020 · 4 comments · Fixed by #60901
Closed

Saving Discover/Visualize/Dashboard/Graph saved objects allows duplicate titles #60735

kertal opened this issue Mar 20, 2020 · 4 comments · Fixed by #60901
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Saved Objects Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kertal
Copy link
Member

kertal commented Mar 20, 2020

Kibana version:
master, other versions have to be tested

Describe the bug:
When you save a new dashboard/saved search/visualize/graph, and choose an already existing name, you'll get a warning, that once you click on save again, the existing saved object will be overwritten. However, this is not the case, there's a new entry with the same name available.

Steps to reproduce:

  1. Create a dashboard, save it named 'test'
  2. Save it again, selecting "Save as a new dashboard", don't change the name

Bildschirmfoto 2020-03-20 um 12 34 13

  1. Confirm to overwrite by clicking on 'Save', now you've a duplicate in you dashboard list.

Bildschirmfoto 2020-03-20 um 12 36 02

Expected behavior:

Dashboard should we overwritten

@kertal kertal added bug Fixes for quality problems that affect the customer experience Feature:Saved Objects Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes
Copy link
Contributor

timroes commented Mar 20, 2020

I wonder if this ever should have worked? I can't remember we ever overwrote saved object "by title" when saving. Do we really want to overwrite here, or rather just prevent saving something with the same title that already exists?

@kertal
Copy link
Member Author

kertal commented Mar 23, 2020

I think the text of this save box was changed, but not the behavior. See 6.8 dashboard save

Bildschirmfoto 2020-03-23 um 07 02 50

You're right, it never worked, to have a given duplicate overwritten. And I think it's fine, if a user want's a duplicate, she/he can have a duplicate. So we've just to adjust the message.

@timroes
Copy link
Contributor

timroes commented Mar 23, 2020

The text was changed in #47443 but the behavior stayed the same, so I'd suggest we revert (or find a new good) wording for the dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Saved Objects Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants