Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPM] Improve and test expandFields() implementation #60487

Closed
skh opened this issue Mar 18, 2020 · 1 comment
Closed

[EPM] Improve and test expandFields() implementation #60487

skh opened this issue Mar 18, 2020 · 1 comment
Assignees
@skh
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@skh
Copy link
Contributor

skh commented Mar 18, 2020

Currently, the implementation of expandFields() in ingest_manager/server/services/epm/fields/field.ts is mutating its input array instead of returning a new one. This is asking for trouble down the road, and inconsistent with our usual style.

This task is to fix the implementation, and also add unit tests.
@skh skh added the Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project label Mar 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

This was referenced Mar 18, 2020
Closed
Merged
@skh skh self-assigned this Mar 26, 2020
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
@skh skh mentioned this issue Apr 1, 2020
Merged
@skh skh closed this as completed Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skh skh

Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skh @jen-huang @elasticmachine