Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index Management mappings tab can freeze browser with large mappings #60398

Closed
cjcenizal opened this issue Mar 17, 2020 · 1 comment · Fixed by #60420
Closed

Index Management mappings tab can freeze browser with large mappings #60398

cjcenizal opened this issue Mar 17, 2020 · 1 comment · Fixed by #60420
Labels
bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@cjcenizal
Copy link
Contributor

Per @P1llus, clicking the "Mappings" tab in Index Management's detail panel can freeze the browser if the mappings are large (on 7.6.1). Here's the UI in question:

image

The problem is that the code editor component spends a lot of cycles updating the DOM. We fixed this issue in Index Templates by using the EuiCodeEditor component to render the mappings (https://github.com/elastic/kibana/blob/master/x-pack/plugins/index_management/public/application/sections/home/template_list/template_details/tabs/tab_mappings.tsx#L22). The same solution can be used here.
@cjcenizal cjcenizal added bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Mar 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth alisonelizabeth mentioned this issue Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[IM] Use EuiCodeBlock to render index mapping alisonelizabeth/kibana
2 participants
@cjcenizal @elasticmachine