Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Painless Lab] Documentation links are hard-coded #60024

Closed
alisonelizabeth opened this issue Mar 12, 2020 · 2 comments
Closed

[Painless Lab] Documentation links are hard-coded #60024

alisonelizabeth opened this issue Mar 12, 2020 · 2 comments
Assignees
@jloleysens
Labels
bug Fixes for quality problems that affect the customer experience Feature:Painless Lab Dev tool for learning Painless painless painless Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@alisonelizabeth
Copy link
Contributor

There are several places in the code where the documentation urls are hard-coded.

One example: https://github.com/elastic/kibana/blob/app/painless/x-pack/legacy/plugins/painless_lab/public/components/main_controls.tsx#L32

We should fix this to use the NP documentation service.
@alisonelizabeth alisonelizabeth added bug Fixes for quality problems that affect the customer experience painless painless Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Mar 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth alisonelizabeth mentioned this issue Mar 12, 2020
Merged
@cjcenizal cjcenizal mentioned this issue Mar 13, 2020
Merged
13 tasks
@jloleysens jloleysens mentioned this issue Mar 19, 2020
Merged
@cjcenizal cjcenizal added the Feature:Painless Lab Dev tool for learning Painless label Mar 23, 2020
@alisonelizabeth
Copy link
Contributor Author

Fixed via #60603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jloleysens jloleysens

Labels
bug Fixes for quality problems that affect the customer experience Feature:Painless Lab Dev tool for learning Painless painless painless Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cjcenizal @alisonelizabeth @jloleysens @elasticmachine