Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting and action APIs to follow kibana STYLEGUIDE #59799

Closed
mikecote opened this issue Mar 10, 2020 · 4 comments · Fixed by #66838
Closed

Alerting and action APIs to follow kibana STYLEGUIDE #59799

mikecote opened this issue Mar 10, 2020 · 4 comments · Fixed by #66838
Assignees
@YulNaumenko
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

Styleguide: https://github.com/elastic/kibana/blob/master/STYLEGUIDE.md#api-endpoints

Kibana uses snake_case for the entire API, just like Elasticsearch. All urls, paths, query string parameters, values, and bodies should be snake_case formatted.
@mikecote mikecote added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Mar 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@pmuellr
Copy link
Member

pmuellr commented Mar 10, 2020

Seems like a big hit, guessing mainly be in request/response bodies, which will then bubble down to everything else, heh. TS will help here, I'm sure.

@mikecote
Copy link
Contributor Author

This issue should be broken down. By route or by layer (query, body, response, objects, etc).

@mikecote
Copy link
Contributor Author

mikecote commented May 5, 2020

Should be done at the same time / person as #63130.

@mikecote mikecote mentioned this issue May 5, 2020
Closed
@YulNaumenko YulNaumenko self-assigned this May 5, 2020
@YulNaumenko YulNaumenko mentioned this issue May 16, 2020
Merged
@mikecote mikecote mentioned this issue Aug 11, 2020
Closed
36 tasks
@mikecote mikecote mentioned this issue Oct 16, 2020
Merged
3 tasks
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
5 participants
@pmuellr @kobelb @mikecote @elasticmachine @YulNaumenko