Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event log license check #58866

Closed
mikecote opened this issue Feb 28, 2020 · 7 comments
Closed

Event log license check #58866

mikecote opened this issue Feb 28, 2020 · 7 comments
Labels
blocked Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

The event log should do a license check for gold+ and handle the dynamics of license changes.

@mikecote mikecote added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Feb 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@pmuellr
Copy link
Member

pmuellr commented Feb 28, 2020

For the server, we'll need a way to dynamically enable/disable the event log, based on the license change.

I guess if the user starts with basic, we shouldn't create the ES resources, but then that means if they move to trial / gold, we would need to create the ES resources outside of the typical plugin setup. Seems like this can be made to work in a fairly straight-forward manner. The eventLoggers will likely have to check the license status (hopefully a property in the plugin, not an ES call) to determine whether to write entries or not.

@mikecote
Copy link
Contributor Author

mikecote commented Mar 5, 2020

but then that means if they move to trial / gold, we would need to create the ES resources outside of the typical plugin setup

Yeah, I'm curious how others do this 🤔at least the initialization code that we need to run is contained.

@mikecote
Copy link
Contributor Author

Marking as blocked until we have requirements for license checks (discussion pending).

@gmmorris gmmorris self-assigned this Apr 3, 2020
@gmmorris
Copy link
Contributor

gmmorris commented Apr 3, 2020

Wouldn't it make more sense for the event log to set itself up no matter what and simply do license checks when the APIs are called?
That way solutions using the Event Log can create loggers without having to special case and the loggers themselves simply decide what action to execute and what action to "drop" (or even reject) when the license isn't good enough for the specific ability?

@gmmorris gmmorris removed their assignment Apr 3, 2020
@gmmorris gmmorris self-assigned this Apr 3, 2020
@mikecote
Copy link
Contributor Author

mikecote commented Apr 3, 2020

It looks like we may not need to implement license checks if the event log is going to be in Basic. I'd hold off working on this issue and we can close this next week once confirmed.

@gmmorris gmmorris removed their assignment Apr 6, 2020
@mikecote
Copy link
Contributor Author

mikecote commented Apr 6, 2020

Closing issue as we will not need license checks for now.

@mikecote mikecote closed this as completed Apr 6, 2020
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

No branches or pull requests

5 participants