Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using/throwing boom errors in the NP elasticsearch service #57458

Closed
pgayvallet opened this issue Feb 12, 2020 · 4 comments
Closed

Stop using/throwing boom errors in the NP elasticsearch service #57458

pgayvallet opened this issue Feb 12, 2020 · 4 comments
Labels
Feature:Legacy Removal Issues related to removing legacy Kibana Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

ATM, any error thrown by the ES client/service is a wrapped boom error

export interface ElasticsearchError extends Boom {
[code]?: string;
}

This made sense in the legacy platform, however in NP we are discouraging usage of boom errors in favor of manual error handling (mostly in the route handlers). We should return non-boom, specialised errors instead.

@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Feb 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@joshdover joshdover added the Feature:Legacy Removal Issues related to removing legacy Kibana label Apr 26, 2020
@joshdover
Copy link
Contributor

Given that we're doing #35508, is this worth doing at all or should we just wait until we remove it?

@pgayvallet
Copy link
Contributor Author

I think we should just wait until the removal of the legacy ES client 'resolves' this issue.

@rudolf
Copy link
Contributor

rudolf commented Oct 9, 2023

This has been fixed 🥳 (probably as part of #35508)

@rudolf rudolf closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Legacy Removal Issues related to removing legacy Kibana Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

4 participants