Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] [Meta] Provide a dedicated image panel #57241

Closed
11 tasks
Tracked by #118429 ...
AlonaNadler opened this issue Feb 10, 2020 · 3 comments
Closed
11 tasks
Tracked by #118429 ...

[Dashboard] [Meta] Provide a dedicated image panel #57241

AlonaNadler opened this issue Feb 10, 2020 · 3 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:Dashboard Dashboard related features Meta Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@AlonaNadler
Copy link

AlonaNadler commented Feb 10, 2020

As part of the dashboard redesign. Allow users to add an image as a panel in a dashboard.
Currently, the way to add an image to a dashboard is using Markdown. However that is very hidden capability, it is not intuitive - users need to use markdown to add an image and frequently being missed. In addition image in markdown can only be added using a URL and not upload an image

It would be good to have an explicit add image panel where users can upload and image or add an image URL as part of the dashboard toolbar we are planning.

Allowing users to add an image will help create more customized dashboards.

Dependencies

  • File storage service

Tasks

Plugin & Services

  • Create image saved object
    • id (keyword): unique saved object id
    • value (binary): base64 dataurl
  • Create image embeddable factory
    • should be backed by image expression
    • should this live in the expression-image plugin?
  • Move asset function to image expression plugin
    • Rewrite asset function to retrieve saved objects instead of retrieving assets stored on workpad
    • Do we need to implement Canvas asset migration simultaenously? Do we need to create a new savedImage function for retrieving image saved objects and deprecate asset later?

Design & UI

  • Should allow uploading images, entering a link to a hosted image, or selecting from the existing stored images
  • Create standalone image upload/editor
    • Can reuse image upload form from Canvas
    • create action for displaying form in modal?
    • this component should be used for inline edit
  • Create UI for managing images
    • can reuse asset manager component from Canvas

Dashboard Integration

  • Add as quick button on toolbar and editor menu option in Dashboard
  • Add a button somewhere to manage images?

Canvas Integration

  • Switch to storing workpad assets as image saved objects instead of persisting assets to the workpad saved object
  • Migrate assets stored on existing workpads and write them as image saved objects
@AlonaNadler AlonaNadler added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added enhancement New value added to drive a business result Feature:Dashboard Dashboard related features labels Feb 12, 2020
@timroes timroes added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 7, 2020
@ghudgins
Copy link

+1 from a customer who'd like to have image upload support in dashboard. IT administrator was checking before spending the energy to host images somewhere in their infrastructure / network.

@ryankeairns ryankeairns changed the title Provide a dedicated image panel in dashboard [Dashboard] Provide a dedicated image panel in dashboard Nov 12, 2021
@cqliu1 cqliu1 changed the title [Dashboard] Provide a dedicated image panel in dashboard [Dashboard][Meta] Provide a dedicated image panel Dec 2, 2021
@cqliu1 cqliu1 added the Meta label Dec 2, 2021
@cqliu1 cqliu1 changed the title [Dashboard][Meta] Provide a dedicated image panel [Dashboard] [Meta] Provide a dedicated image panel Dec 2, 2021
@cqliu1 cqliu1 self-assigned this Feb 7, 2022
@cqliu1
Copy link
Contributor

cqliu1 commented Feb 9, 2023

Closed with #146421.

@cqliu1 cqliu1 closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Dashboard Dashboard related features Meta Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

5 participants