Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana Platform creates two HTTP services #57148

Closed
jportner opened this issue Feb 7, 2020 · 1 comment · Fixed by #57150
Closed

Kibana Platform creates two HTTP services #57148

jportner opened this issue Feb 7, 2020 · 1 comment · Fixed by #57150
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@jportner
Copy link
Contributor

jportner commented Feb 7, 2020

Kibana version: 7.6 RC+

Describe the bug: The Kibana Platform creates two HTTP services (one for setup, one for start). As a result, HTTP request/response interceptors in the Kibana Platform don't always get triggered.

Steps to reproduce: To quickly verify this behavior, in src/core/public/http/fetch.ts, add the following line at the beginning of the fetch method:

console.log(`fetch (interceptors: ${this.interceptors.size})`);

Then, log into Kibana and view the console to see fetch requests going through both HTTP services. Example:
image

Any additional context: It appears that a change to http_service.ts in #53033 inadvertently resulted in the plugin setup and start methods each receiving a different version of the HTTP service. If interceptors were registered during setup, they would not be affected by requests that were made with the HTTP service from start (and vice versa). Special thanks to @legrego for doing the heavy lifting in troubleshooting!

@jportner jportner added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc triaged labels Feb 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants