Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move saved objects helper to new platform #56954

Closed
flash1293 opened this issue Feb 6, 2020 · 1 comment · Fixed by #57452
Closed

Move saved objects helper to new platform #56954

flash1293 opened this issue Feb 6, 2020 · 1 comment · Fixed by #57452
Assignees
Labels
Feature:NP Migration Feature:Saved Objects Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

There are some helpers around saved objects currently located in src/legacy/ui/public/saved_objects/saved_object_loader.ts and src/legacy/ui/public/saved_objects/saved_object.ts.

Those together with the helper utilities in src/legacy/ui/public/saved_objects/helpers should get moved into the newly created saved_objects NP plugin. The createSavedObjectClass helper and SavedObjectLoader class should be exposed as static exports from the top level of the plugin. All consumers should switch to the new location directly (no proxying via re-export file still in ui/public).

The tests located in src/legacy/ui/public/saved_objects/__tests__ should get converted also moved over in the same step. The test for SimpleSavedObject can be moved into core (the implementation is already located there).

@flash1293 flash1293 added Feature:Saved Objects Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:NP Migration labels Feb 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration Feature:Saved Objects Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants