Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load exact hit count async #55975

Closed
timroes opened this issue Jan 27, 2020 · 3 comments
Closed

Load exact hit count async #55975

timroes opened this issue Jan 27, 2020 · 3 comments
Labels
blocked enhancement New value added to drive a business result Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Jan 27, 2020

The new format of hits.total will by default only calculate estimated counts, which can improve querying performance significantly.

Since we don't need an exact count in Discover, I would suggest by default we're actually showing the estimated count, with some info icon behind it. If you click this, you would get a popover (similar to the KQL one in the query bar), explaining you, that we only show estimated counts, due to performance, and give the user a switch, which which they could opt into exact counts, in which case we would request the exact amount and show it (that switch could be saved with the discover search).

Update: In some discussion with Vijay we decided that we might just do the query to count the documents always (or have an advanced setting to configure it), just also as a separate request, and just show the "estimated hits" that will be returned with the document query, until the count query is done and we then just switch the estimate hits by the real hit count.

Part of #69134
Related #26356
Blocked by #55974

@timroes timroes added blocked Feature:Discover Discover Application enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes changed the title Only show estimated count of hits in Discover Load exact hit count async Oct 5, 2020
@timroes
Copy link
Contributor Author

timroes commented Nov 3, 2020

Liza has done some measures of different queries (see this comment) which gives us a good understanding of HOW FAST actually we'll get by not using the document query anymore to load the exact hit time.

We can improve the performance potentially 10 times (look at the "LATEST w/totals, w/sort" vs "LATEST wo/totals, w/sort" column) for larger clusters.

@timroes
Copy link
Contributor Author

timroes commented Nov 5, 2020

Closing in favor of #69134

@timroes timroes closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement New value added to drive a business result Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants