Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UISettings accessors from core setup contract #55396

Closed
pgayvallet opened this issue Jan 21, 2020 · 2 comments
Closed

Remove UISettings accessors from core setup contract #55396

pgayvallet opened this issue Jan 21, 2020 · 2 comments
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

In #55012 we decided to remove any API that could allow to access/query savedObjects from core setup contract, and move them to the start contract instead.

We should now to the same regarding UiSettings. The only API impacted is asScopedToClient
@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Jan 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

This was referenced Jan 21, 2020
Merged
Closed
@mshustov mshustov mentioned this issue May 13, 2020
Open
@pgayvallet
Copy link
Contributor Author

This was fixed a while ago. The setup contract of the uiSettings service no longer exposes API to read/write settings.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pgayvallet @elasticmachine