Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UiSettings client to action and alert executor's services parameter #55052

Closed
pmuellr opened this issue Jan 16, 2020 · 2 comments
Closed
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.1 v8.0.0

Comments

@pmuellr
Copy link
Member

pmuellr commented Jan 16, 2020

The services parameter for actions and alerts currently only provides access to callCluster and savedObjectsClient.

export interface Services {
callCluster(path: string, opts: any): Promise<any>;
savedObjectsClient: SavedObjectsClientContract;
}

export interface Services {
callCluster(path: string, opts: any): Promise<any>;
savedObjectsClient: SavedObjectsClientContract;
}

@chrisronline has requested access to the UI Settings client as well. He's currently stitching one together himself, with code copied from:

export function uiSettingsServiceFactory(
server: Legacy.Server,
options: UiSettingsServiceFactoryOptions
): IUiSettingsClient {
return server.newPlatform.__internals.uiSettings.asScopedToClient(options.savedObjectsClient);
}

Copying these services in manually doesn't seem like it's going to scale, if we get a bunch more. Not quite sure what the best approach to avoid doing that might be.

Adding one more though isn't a huge issue.

@pmuellr pmuellr added Feature:Alerting v8.0.0 v7.7.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jan 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@ymao1
Copy link
Contributor

ymao1 commented Apr 23, 2021

Closing in favor of #64588

@ymao1 ymao1 closed this as completed Apr 23, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.1 v8.0.0
Projects
None yet
Development

No branches or pull requests

5 participants