-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate the bootstrap.js endpoint to Kibana Platform #54375
Comments
Pinging @elastic/kibana-platform (Team:Platform) |
I think we are going to have an issue here because the kibana/src/legacy/ui/ui_render/ui_render_mixin.js Lines 92 to 98 in 054ec70
Other things to solve:
and (I think ?)
|
It looks like we're only using the The getUiApp + getHiddenUiApp logic is obsolete in the new platform because we always render the same core bundle. I believe the uiExports.stylesheet issue will be resolved once sass-loader is added to our Webpack config in #53532 and all plugins migrate to using webpack imports for styles. |
Yes, however if we migrate now we will still need it to render legacy apps. |
Instead of migrating bootstrap.js, could we get rid of it and move the logic to the main page template? I have always felt that the bootstrap file was a needless delay. |
We probably can yea, even if I'd prefer to first migrate the endpoint before trying to factorize it with the rendering service logic. |
TIL, because of our CSP policy, we can't inline |
Currently the logic for rendering the
bootstrap.js
endpoint exists in the legacyui_render_mixin
. Now that the server rendering service exists, we should be able to move this routing logic to the new platform.The text was updated successfully, but these errors were encountered: