Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor alerts client tests #53944

Closed
mikecote opened this issue Jan 3, 2020 · 3 comments
Closed

Refactor alerts client tests #53944

mikecote opened this issue Jan 3, 2020 · 3 comments
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

mikecote commented Jan 3, 2020

The alerts client jest test file has grown to > 2300 lines of code and has become hard to maintain and navigate. The number of lines need to be reduced and have less repetition.
@mikecote mikecote added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jan 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote mentioned this issue Jun 12, 2020
Merged
6 tasks
@YulNaumenko
Copy link
Contributor

I think we already did it in the PR by the splitting to the separate files and exposing repeating code to a lib folder.

@mikecote
Copy link
Contributor Author

@YulNaumenko Yup, you are correct. I will close this issue now 🙏

@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kobelb @mikecote @elasticmachine @YulNaumenko