You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a meta issue for cleaning up the functional UI tests, born from my work on #5292
The following things can be cleaned up/fixed and should be opened as new issues:
Leadfoot's setFindTimeout appears to be a universal setting, so it does not need to be called with every find operation
It's possible I'm reading the docs wrong here. If I'm wrong, and it's a per-find setting, then we should at least wrap it instead of calling it every time...
Common.tryForTime currently returns the time it took to pass. Having it return the passing value instead would clean up several duplicate operations and allow cleaner use like common.tryForTime(...).then(function (val) {}) (Common.tryForTime should return the resolved value #5487)
Using tryForTime in the find operations isn't required if all you're trying to get is the element on the page, setFindTimeout continues to try finding an element until the timeout is reached
tryForTime throws a timeout error when timeout is reached, might be handy for debugging if it re-threw the last error it got instead
The debug setting coming from the intern could/should be set based on the runtime environment
There may also be some timeouts we'd want to tweak based on the runner's env
Currently, all tests have a 90s timeout, mostly due to the server recovery taking a long time. Now that there's a config value for timeouts, it might be nice to give that specific timeout its own value.
The text was updated successfully, but these errors were encountered:
This is a meta issue for cleaning up the functional UI tests, born from my work on #5292
The following things can be cleaned up/fixed and should be opened as new issues:
Common.tryForTime
currently returns the time it took to pass. Having it return the passing value instead would clean up several duplicate operations and allow cleaner use likecommon.tryForTime(...).then(function (val) {})
(Common.tryForTime should return the resolved value #5487)tryForTime
in the find operations isn't required if all you're trying to get is the element on the page,setFindTimeout
continues to try finding an element until the timeout is reachedtryForTime
throws a timeout error when timeout is reached, might be handy for debugging if it re-threw the last error it got insteaddebug
setting coming from the intern could/should be set based on the runtime environmentThe text was updated successfully, but these errors were encountered: