Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional UI Test Cleanup #5362

Closed
2 of 8 tasks
w33ble opened this issue Nov 10, 2015 · 2 comments
Closed
2 of 8 tasks

Functional UI Test Cleanup #5362

w33ble opened this issue Nov 10, 2015 · 2 comments
Labels

Comments

@w33ble
Copy link
Contributor

w33ble commented Nov 10, 2015

This is a meta issue for cleaning up the functional UI tests, born from my work on #5292

The following things can be cleaned up/fixed and should be opened as new issues:

  • Leadfoot's setFindTimeout appears to be a universal setting, so it does not need to be called with every find operation
    • It's possible I'm reading the docs wrong here. If I'm wrong, and it's a per-find setting, then we should at least wrap it instead of calling it every time...
  • Common.tryForTime currently returns the time it took to pass. Having it return the passing value instead would clean up several duplicate operations and allow cleaner use like common.tryForTime(...).then(function (val) {}) (Common.tryForTime should return the resolved value #5487)
  • Using tryForTime in the find operations isn't required if all you're trying to get is the element on the page, setFindTimeout continues to try finding an element until the timeout is reached
  • Consistent timeout lengths when sleeping, looking for elements, etc, unless specific reason to change it (Toast check speedup and timeout increases #5495)
  • Consistent debug message format and usage
  • tryForTime throws a timeout error when timeout is reached, might be handy for debugging if it re-threw the last error it got instead
  • The debug setting coming from the intern could/should be set based on the runtime environment
    • There may also be some timeouts we'd want to tweak based on the runner's env
  • Currently, all tests have a 90s timeout, mostly due to the server recovery taking a long time. Now that there's a config value for timeouts, it might be nice to give that specific timeout its own value.
@tylersmalley
Copy link
Contributor

@w33ble anything here still relevant? cc: @silne30

@w33ble
Copy link
Contributor Author

w33ble commented Aug 7, 2018

No idea. Probably not... do we even use leadfoot anymore, or have any of these helpers? I haven't written selenium tests in a long time.

Erring on the side of closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants