Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embeddables] Extra type safety #52887

Closed
stacey-gammon opened this issue Dec 12, 2019 · 2 comments
Closed

[Embeddables] Extra type safety #52887

stacey-gammon opened this issue Dec 12, 2019 · 2 comments
Labels
Feature:Embedding Embedding content via iFrame impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@stacey-gammon
Copy link
Contributor

It'd be great to get the input and output shapes typed correctly based on the type of embeddable so we get more type safety and don't have to cast. Especially when EmbeddableFactoryRenderer is introduced, this lacks type safety and input shape can be mismatched to the type passed in. I think we can do something similar to how the data search services does this with the request and response shapes mapped by search type.

@stacey-gammon stacey-gammon added Feature:Embedding Embedding content via iFrame Team:AppArch labels Dec 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@ppisljar
Copy link
Member

ppisljar commented Aug 8, 2022

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Embedding Embedding content via iFrame impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Development

No branches or pull requests

3 participants