Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] NP migration StaticIndexPattern -> IIndexPattern #51541

Closed
ogupte opened this issue Nov 22, 2019 · 1 comment
Closed

[APM] NP migration StaticIndexPattern -> IIndexPattern #51541

ogupte opened this issue Nov 22, 2019 · 1 comment
Assignees
@smith
Labels
good first issue low hanging fruit v7.6.0

Comments

@ogupte
Copy link
Contributor

ogupte commented Nov 22, 2019 •
edited
Loading

Meta issue: #32894

In https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/apm/server/lib/index_pattern/get_dynamic_index_pattern.ts#L7

Remove:

import { StaticIndexPattern } from 'ui/index_patterns';

and replace references of the legacy StaticIndexPattern with the new IIndexPattern which is already imported in that file.
@jasonrhodes jasonrhodes mentioned this issue Nov 22, 2019
Closed
@ffknob
Copy link
Contributor

ffknob commented Nov 26, 2019

I think this one could be closed because of #51689

@smith smith self-assigned this Nov 26, 2019
@smith smith closed this as completed Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smith smith

Labels
good first issue low hanging fruit v7.6.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smith @sorenlouv @ogupte @ffknob