Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripted Fields Lack Validation #5088

Closed
panda01 opened this issue Oct 9, 2015 · 4 comments
Closed

Scripted Fields Lack Validation #5088

panda01 opened this issue Oct 9, 2015 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Scripted Fields Scripted fields features

Comments

@panda01
Copy link
Contributor

panda01 commented Oct 9, 2015

When creating a scripted field, if you use a field that isn't a numeral, when you go to discover Kibana just kind of barfs on itself.

Since we can get the field types from ES, i think we should use those to help the user along with making them.

Also, When you input a non valid value into the formatters, no error is thrown, or anything indicating that that value, will not work.

This probably will need to be broken down, into two actionable tasks.

Repro

  • Creating a field that uses doc['cluster.state.status'].value
  • Go to Discover
  • That field is the only field in the sidebar, and Discover does not load
@panda01 panda01 added the bug Fixes for quality problems that affect the customer experience label Oct 9, 2015
@panda01 panda01 changed the title Scripted Fields Lacks Validation Scripted Fields Lack Validation Oct 9, 2015
@panda01
Copy link
Contributor Author

panda01 commented Oct 9, 2015

Discovered while messing with #4594.

@panda01
Copy link
Contributor Author

panda01 commented Oct 9, 2015

No validation

@tbragin tbragin added Feature:Scripted Fields Scripted fields features :Management labels Nov 10, 2016
@w33ble w33ble added the good first issue low hanging fruit label Dec 29, 2016
@w33ble
Copy link
Contributor

w33ble commented Dec 29, 2016

Labeling low fruit because I think we can simply use the scripted field and see if we get an error from Elasticsearch when we try, but it may be more complicated than that.

@nreese
Copy link
Contributor

nreese commented Jul 19, 2018

closed by #20746

@nreese nreese closed this as completed Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Scripted Fields Scripted fields features
Projects
None yet
Development

No branches or pull requests

5 participants