Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Boom errors for non API related files #49822

Open
mikecote opened this issue Oct 31, 2019 · 4 comments
Open

Remove Boom errors for non API related files #49822

mikecote opened this issue Oct 31, 2019 · 4 comments
Labels
estimate:small Small Estimated Level of Effort Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture

Comments

@mikecote
Copy link
Contributor

This would mean to catch errors at the API level and convert to proper status code. This is required for new platform and NP best practices.
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services (Team:Stack Services)

@bmcconaghy bmcconaghy added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) and removed Team:Stack Services labels Dec 12, 2019
@pmuellr
Copy link
Member

pmuellr commented Jan 3, 2020

This shouldn't be too bad. Across actions and alerting, there are only 5 files using Boom and 6 usages of it total, and they are all Boom.badRequest(). For some reason I thought we had some more elaborate usages, guess not!

@pmuellr pmuellr mentioned this issue Mar 19, 2020
Merged
@gmmorris gmmorris mentioned this issue Jun 12, 2020
Merged
6 tasks
@ymao1
Copy link
Contributor

ymao1 commented Mar 4, 2021

@mikecote Does this need to be done by 8.0?

@mikecote
Copy link
Contributor Author

mikecote commented Mar 4, 2021

@ymao1 not for 8.0 based on what I recall. This was regarding migrating to the Kibana Platform, which we did a while ago. Now it just seems bad practice to use Boom errors, I believe.

@YulNaumenko YulNaumenko added the technical debt Improvement of the software architecture and operational architecture label Mar 11, 2021
@gmmorris gmmorris added the loe:medium Medium Level of Effort label Jul 14, 2021
@gmmorris gmmorris added the estimate:small Small Estimated Level of Effort label Aug 18, 2021
@gmmorris gmmorris removed the loe:medium Medium Level of Effort label Sep 2, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
estimate:small Small Estimated Level of Effort Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: No status
Milestone
No milestone
Development

No branches or pull requests
8 participants
@pmuellr @gmmorris @kobelb @bmcconaghy @mikecote @ymao1 @elasticmachine @YulNaumenko