Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Improve support for Cross Cluster Search in Indices settings #49732

Closed
6 tasks
formgeist opened this issue Oct 30, 2019 · 8 comments
Closed
6 tasks

[APM] Improve support for Cross Cluster Search in Indices settings #49732

formgeist opened this issue Oct 30, 2019 · 8 comments
Labels
enhancement New value added to drive a business result stale Used to mark issues that were closed for being stale Team:APM All issues that need APM UI Team support

Comments

@formgeist
Copy link
Contributor

formgeist commented Oct 30, 2019

Related design issue #41366

Summary

We want to allow the user to configure each index pattern in the Indices settings for Cross Cluster Search enabling a user who has several data indices across multiple clusters to include that data in a single instance of APM UI.

Design solution

Building on top of the existing indices settings page, we're extending the existing layout and adding a new option to convert the already input indices to cross cluster search compatible references.

  • Convert existing rows to the EuiDescribedFormGroup component in order to add an explanatory description to each index so it's clearer for the user what each index does.
  • Add option to add CCS parameter.
  • Convert the "Add CSS" button to a text EuiButtonEmpty style with a checkmark icon since the input parameters have been generated.
  • When we show the "Added CCS" button, we will additionally put a small helper text underneath the option to explain the syntax of what we've added.
    add-cross-cluster-with-syntax
  • If an index has CSS index parameters already, we will not show the generate option.
  • Show tooltip by the generate button with copy that explains what Cross Cluster Search means; If you have multiple clusters storing your data, you can enable APM UI to search for those as well.

Prototype & screens

Figma prototype

Kapture 2019-10-30 at 14 38 42

01_d APM - Indices - CCS support
02_d APM - Indices - CCS support
03_d APM - Indices - CCS support
04_d APM - Indices - CCS support

@formgeist formgeist added the Team:APM All issues that need APM UI Team support label Oct 30, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv added the enhancement New value added to drive a business result label Nov 21, 2019
@sorenlouv sorenlouv changed the title [APM] Add support for Cross Cluster Search in Indices settings [APM] Improve support for Cross Cluster Search in Indices settings Nov 21, 2019
@sorenlouv
Copy link
Member

@formgeist Before users can use ccs in APM they have to setup the remote clusters in the management section.

image

It might be possible for us to detect if they've done this. And also detect the names of the remote clusters. This is perhaps v.2 but might be worth thinking about how we can make the integration even smoother (eg. only suggest ccs if they've setup a remote cluster; and in that case suggest specific cluster names)

@formgeist
Copy link
Contributor Author

@sqren Alright, thanks for the heads up. If users add the CCS parameters in the inputs, will it break if they haven't enabled remote clusters? I want to avoid having too many callouts and notifications to the users in our UI.

@sorenlouv
Copy link
Member

sorenlouv commented Dec 16, 2019

If users add the CCS parameters in the inputs, will it break if they haven't enabled remote clusters? I want to avoid having too many callouts and notifications to the users in our UI.

It wont break as such if the user adds apm-*,*:apm-* and they haven't added any remote clusters. But OTOH it won't work as expected either. It'll just search on the local cluster.

Suggestions for phase 2:

  • only show "Add Cross Cluster Indices" link if at least one remote cluster has been added
  • warn the user if they manually type *:apm-* without having added any remote clusters
  • warn the user if they manually type mycluster1:apm-* if they only have a remote cluster named mycluster2.

Similarly we could add a warning if no indices matches the specified pattern.

@formgeist
Copy link
Contributor Author

Suggestions for phase 2:

  • only show "Add Cross Cluster Indices" link if at least one remote cluster has been added
  • warn the user if they manually type :apm- without having added any remote clusters
  • warn the user if they manually type mycluster1:apm-* if they only have a remote cluster named - mycluster2.
  • Similarly we could add a warning if no indices matches the specified pattern.

I agree with those suggestions. I'll incorporate them in my next revisions and post an update 👍

@formgeist
Copy link
Contributor Author

Opened a new design issue to handle those improvements elastic/apm#189

@botelastic
Copy link

botelastic bot commented Nov 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale Used to mark issues that were closed for being stale label Nov 1, 2021
@sorenlouv
Copy link
Member

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result stale Used to mark issues that were closed for being stale Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

5 participants