Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary src/plugins/kibana_react eslint overrides #49556

Closed
spalger opened this issue Oct 28, 2019 · 3 comments
Closed

Remove temporary src/plugins/kibana_react eslint overrides #49556

spalger opened this issue Oct 28, 2019 · 3 comments
Labels
chore impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@spalger
Copy link
Contributor

spalger commented Oct 28, 2019

In order to move forward with #49244 we needed to disable some rules in src/plugins/kibana_react. We need to remove the related overrides and get the package passing these rules pretty soon.

// .eslintrc.js
{
  files: ['src/plugins/kibana_react/**/*.{js,ts,tsx}'],
  rules: {
    'react-hooks/rules-of-hooks': 'off',
    'react-hooks/exhaustive-deps': 'off',
  },
},
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@ppisljar
Copy link
Member

ppisljar commented Aug 9, 2022

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2022
@spalger
Copy link
Contributor Author

spalger commented Aug 10, 2022

Looks like this was fixed as part of some other change

@spalger spalger closed this as completed Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Development

No branches or pull requests

4 participants