Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Filter autocomplete off #4874

Closed
becker-IT opened this issue Sep 7, 2015 · 21 comments
Closed

Dashboard Filter autocomplete off #4874

becker-IT opened this issue Sep 7, 2015 · 21 comments

Comments

@becker-IT
Copy link

While autocomplete for the filter input html on the dashboard is not turned off, it's impossible to target the results. I think to disable the browser history for these filter input's would be a little improvement.

@spalger
Copy link
Contributor

spalger commented Sep 9, 2015

@becker-IT if you click out of the input box, does the autocomplete go away?

@becker-IT
Copy link
Author

Nope, I click

Dashboard
Open saved Dashboard
Type for example "A" in the input field

and the result is I can't target the saved dashboards because the browser history is in front. When I click again in the input field the browser history is loading again.

@rashidkpc
Copy link
Contributor

Hit escape and the autocomplete will dismiss

@becker-IT
Copy link
Author

Ah I see, what a perfect solution!
I prefer this one: autocomplete="off"

@hollowimage
Copy link

@becker-IT where did you set that?

@kevin-m-rego
Copy link

This option is awful. I have to hit escape after ever letter I delete... HATE it

@hollowimage
Copy link

hollowimage commented Aug 3, 2016

It would be fine if

  1. the focus did not switch from typing to the autocomplete,
  2. the autocomplete would appear BELOW the bar.

otherwise like @kevin-m-rego mentioned, modifying queries from previous completes (say i want to change a few things on the end, like a port number) is worse than dueling with chrome autocomplete.

@qrilka
Copy link

qrilka commented Aug 10, 2016

That autocomplete thing is very annoying, I suppose it's status is "feature, not a bug"?

@MaxBosse
Copy link

I completely agree with @hollowimage. With these 2 improvements I would be totally fine but right now it's basically unusable if you don't have 5 minutes to change one query...

@Bargs
Copy link
Contributor

Bargs commented Aug 10, 2016

I'm not sure I understand the problem. Are you having trouble with the browser's autocomplete, or Kibana's autocomplete? Which version of Kibana? And what's happening exactly? Some screenshots or a gif would be great.

@scampi
Copy link
Contributor

scampi commented Aug 12, 2016

@Bargs it seems that the browser's autocomplete is messing with the input field. I managed to reproduce the problem, but on the discover page though. I hope nonetheless this is useful:

output

This was tested on:

  • Kibana 4.5.3 (I can try with latest if you want, I just happened to be working with that version)
  • Chrome Version 52.0.2743.116 (64-bit)

The browser autocompletion seems to be (nearly) always on the way. You can see that the "lense" icon on the right disappears when this is the case.

@Bargs
Copy link
Contributor

Bargs commented Aug 12, 2016

@scampi that issue was fixed in 4.5.4.

@MaxBosse is this the same issue you're seeing?

@MaxBosse
Copy link

Yes it is the same issue I was seeing, I will make sure we are updating to the latest version, thanks @Bargs 👍

@qrilka
Copy link

qrilka commented Aug 14, 2016

@Bargs updating to 4.5.4 helped, thanks a lot

@ikoniaris
Copy link

Was this issue fixed in the 4.1.x branch (for older Elasticsearch versions) as well? And if yes, which version?

@Bargs
Copy link
Contributor

Bargs commented Aug 18, 2016

@ikoniaris fixed in 4.1.11

@metaturso
Copy link

For anyone affected from this aggravating issue there's a quick way to get rid of the suggestion box to regain control over what you type.

Admittedly not the ideal solution, but it works in an environment where you can't afford to update Kibana to fix a trivial UI issue.

The workaround consists in removing the change, focus, and keydown event listeners through the Chrome Inspector (Inspect element searchSource, then from the CSS pane go to Event Listeners to find the listeners to unbind) so that you can type freely in the search bar.

@knepperjm
Copy link

What version of Kibana can I use with ES to implement the fix or are there no compatible versions of Kibana with the fix that are compatible with ES version v1.5? I see the 4.1.x versions fix the issue, but are those compat. with v1.5 of ES? Thanks!

@SleepyBrett
Copy link

SleepyBrett commented Nov 7, 2016

I got so fed up with this 'feature' today on 4.1.x that I whipped up a little grease/violet/whatever monkey script to deal with it

// ==UserScript==
// @name Kibana autocomplete killer
// @namespace kibana
// @grant none
// @include https://<your kibana site>/*
// ==/UserScript==

function main() {
  document.addEventListener('click', function() {
    var jq = window.jQuery

    var searchbox = jq('.input-group input')
    searchbox.unbind("change");
    searchbox.unbind("focus");
    searchbox.unbind("keydown");

    console.log("removed");
  });
};

var script = document.createElement("script");
script.textContent = "(" + main.toString() + ")();";
document.body.appendChild(script);

@lvhao
Copy link

lvhao commented Dec 7, 2016

thanks for @SleepyBrett 's script ,it works well for me.

@metaturso
Copy link

Thanks @SleepyBrett.

FWIW I have found a much simpler CSS workaround (source: Kibana issue #7801) which works very well but it needs an extension like Stylish or Stylebot.

.typeahead .typeahead-items { 
  top: 32px; 
} 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests