Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Migration Guide #48245

Closed
2 of 8 tasks
joshdover opened this issue Oct 15, 2019 · 8 comments
Closed
2 of 8 tasks

Improve Migration Guide #48245

joshdover opened this issue Oct 15, 2019 · 8 comments
Assignees
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc triage_needed

Comments

@joshdover
Copy link
Contributor

joshdover commented Oct 15, 2019

This is an issue to track improvements that should be made to the Migration Guide and accompanying docs.

The goal of the guide is to provide all necessary guidance to successfully move a legacy plugin to the New Platform.

Improvements

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Oct 15, 2019
@joshdover joshdover self-assigned this Oct 15, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@mshustov
Copy link
Contributor

@rudolf
Copy link
Contributor

rudolf commented Oct 16, 2019

@tsullivan
Copy link
Member

https://github.com/elastic/kibana/blob/master/src/core/MIGRATION.md#configure-plugin

In one of the code sections, there is a code comment saying ... if config is optional

The guide doesn't explain what optional config means. If there is config that has default settings, would it always exist? In other words, would a config never be optional if it has a default?

@mshustov
Copy link
Contributor

mshustov commented Nov 12, 2019

  • Add an example of angular application usage within the new platform and what limitations it has.

@joshdover
Copy link
Contributor Author

joshdover commented Nov 26, 2019

  • Add an example of how to migrate the pre option from Hapi to New Platform router (@joshdover)

@rudolf
Copy link
Contributor

rudolf commented Jan 8, 2020

@joshdover
Copy link
Contributor Author

With the majority of teams having completed their migration I am closing this issue. Whenever we focus on moving this documentation to our public docs, we should focus on reworking this doc for 3rd party plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc triage_needed
Projects
None yet
Development

No branches or pull requests

5 participants