Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Support metadata editing in agent details #48022

Closed
mattapperson opened this issue Oct 11, 2019 · 7 comments
Closed

[Fleet] Support metadata editing in agent details #48022

mattapperson opened this issue Oct 11, 2019 · 7 comments
Assignees
Labels
Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@mattapperson
Copy link
Contributor

Should not allow metadata sent from agent to be updated in the UI

@mattapperson mattapperson added the Feature:Fleet Fleet team's agent central management project label Oct 11, 2019
@nchaulet nchaulet mentioned this issue Oct 11, 2019
44 tasks
@nchaulet
Copy link
Member

@mdefazio any thought on how implementing this? maybe a mockup? :)

@mdefazio
Copy link
Contributor

Am I understanding this correctly that there will be read-only key:value pairs in the meta data, and others that are editable/added by user? @nchaulet

@mattapperson
Copy link
Contributor Author

@mdefazio Correct. Metadata sent from the agent itself will be read only. But we will also support user-provided metadata that will be editable

@mattapperson
Copy link
Contributor Author

In my mind we could just display the non-editable metadata as a grey-ish disabled look. With a tooltip that states that this metadata is sent from the agent and thus can't be changed from the UI.

@mdefazio
Copy link
Contributor

Here's an updated view of the agent detail view with the meta data. Prototype also updated

image

Adding meta data can happen in popover.
Add Meta Data GIF

@mattapperson
Copy link
Contributor Author

@mdefazio this is policy detail not agent details. Policies don't have metadata

@mdefazio
Copy link
Contributor

Sorry about that. Here it is on the agent detail flyout

image

@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

4 participants