Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a legacy compatibility layer for ApplicationService #46481

Closed
joshdover opened this issue Sep 24, 2019 · 1 comment · Fixed by #46659
Closed

Add a legacy compatibility layer for ApplicationService #46481

joshdover opened this issue Sep 24, 2019 · 1 comment · Fixed by #46659
Assignees
@joshdover
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

Legacy plugins cannot currently use the core.application.register API. If they attempt to call it, an exception is throw immediately.

To ease migrations, we should be able to add a legacy version of this API that uses the Legacy chrome.setRootController API under the hood in order to provide a NP-compatible API to Legacy plugins.
@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Sep 24, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

This was referenced Sep 24, 2019
Closed
Merged
@joshdover joshdover self-assigned this Sep 25, 2019
@justinkambic justinkambic mentioned this issue Sep 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshdover joshdover

Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add compatibility layer for ApplicationService in legacy platform joshdover/kibana
2 participants
@joshdover @elasticmachine