Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard modal component name inconsistency. #44977

Closed
sainthkh opened this issue Sep 6, 2019 · 1 comment
Closed

Dashboard modal component name inconsistency. #44977

sainthkh opened this issue Sep 6, 2019 · 1 comment
Labels
Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@sainthkh
Copy link
Contributor

sainthkh commented Sep 6, 2019 •
edited
Loading

When writing #44580, I found name inconsistency.

CloneDashboardModal and DashboardSaveModal => Names are a bit inconsistent. Should we leave them as-is? If not, I think DashboardSaveModal to SaveDashboardModal is a good idea.

This PR is written to continue discussion and make the final decision about how to fix it or to leave it as-is.
@rashmivkulkarni rashmivkulkarni added the Feature:Dashboard Dashboard related features label Sep 12, 2019
@timroes timroes added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Mar 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson added loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Mar 11, 2021
@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@timroes @sainthkh @rashmivkulkarni @ThomThomson @elasticmachine